Adds ability for user to define additional tags for images #1388
+66
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcaroline2020
changed the title
fcaroline2020
force-pushed
the
add-tags
branch
from
4b0b4ee
to
9b4264e
Compare
bkneis
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Thanks for the contribution @fcaroline2020! The implementation looks good to me. Just a couple of small remarks and the lint issues to address
cmd/build.go
Outdated
| @@ -54,6 +54,15 @@ func NewBuildCmd(flags *flags.GlobalFlags) *cobra.Command { | |||
| } | |||
| } | |||
|
|
|||
| // validate tags | |||
| if cmd.Tag != nil { | |||
There was a problem hiding this comment.
cmd.Tag is initialised as []string{} so won't be nil, I think it would be better to check len(cmd.Tag) > 0
pkg/devcontainer/prebuild.go
Outdated
| @@ -87,10 +87,27 @@ func (r *runner) Build(ctx context.Context, options provider.BuildOptions) (stri | |||
| ) | |||
| } | |||
|
|
|||
| // Setup all image tags (prebuild and any user defined tags) | |||
| ImageRefs := []string{prebuildImage} | |||
There was a problem hiding this comment.
nit: imageRefs over ImageRefs
pkg/devcontainer/prebuild.go
Outdated
|
|
||
| // tag the image | ||
| for _, imageRef := range ImageRefs { | ||
| err = dockerDriver.TagDevContainer(ctx, prebuildImage, imageRef) |
There was a problem hiding this comment.
need to check err is not nil or log here
pkg/devcontainer/prebuild.go
Outdated
| if err != nil { | ||
| return "", errors.Wrap(err, "push image") | ||
| for _, imageRef := range ImageRefs { | ||
| err = dockerDriver.PushDevContainer(ctx, imageRef) |
There was a problem hiding this comment.
nit: this could be a one liner with err check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new build cli flag
tagthat will tag the image with the user defined tag and then pushExample CLI command
./devpod-cli build . --devcontainer-path ./devcontainer.json --force-build --debug --tag test,arm64